Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: commit reveal timeouts #24

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Feat: commit reveal timeouts #24

merged 5 commits into from
Oct 1, 2024

Conversation

gluax
Copy link
Contributor

@gluax gluax commented Sep 27, 2024 •
edited
Loading

Motivation

To have timeouts and timeout configs.

Explanation of Changes

Adds:

  • A new sudo query to remove timed out requests(should this be renamed? since it just moves timed out ones to tally?).
  • A new execute query to set the timeout config.
  • A new timeout config.

Testing

New json tests!

Related PRs and Issues

N/A

@gluax gluax self-assigned this Sep 27, 2024
@gluax
Copy link
Contributor Author

gluax commented Sep 27, 2024 •
edited
Loading

@hacheigriega has suggested renaming it from RemoveTimedOutDataRequests to ProcessExpiredDataRequests opinions/thoughts?

I'm a fan :)

@gluax gluax marked this pull request as ready for review September 27, 2024 18:07
Thomasvdam
Thomasvdam approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@Thomasvdam Thomasvdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets double check with Mario on Monday though :)

@gluax gluax merged commit 8becdd7 into main Oct 1, 2024
2 checks passed
@gluax gluax deleted the feat/commit-reveal-timeouts branch October 1, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariocao mariocao mariocao approved these changes

@Thomasvdam Thomasvdam Thomasvdam approved these changes

Assignees

@gluax gluax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gluax @Thomasvdam @mariocao